no-merges: match titles instead of labels #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitaj
added a commit
to pitaj/rust-forge
that referenced
this pull request
Sep 16, 2023
pitaj
force-pushed
the
no-merges_exclude-titles
branch
from
f8d45c0
to
a27cc0f
Compare
This was referenced Sep 16, 2023
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Sep 16, 2023
triagebot exclude_labels -> exclude_titles rust-lang/triagebot#1720
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Sep 21, 2023
disable no-merges check for now It leads to false warnings on sync PRs until rust-lang/triagebot#1720 lands.
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Sep 22, 2023
triagebot exclude_labels -> exclude_titles rust-lang/triagebot#1720
ehuss
reviewed
Sep 22, 2023
Comment on lines
+52
to
+55
| if config | ||
| .exclude_titles | ||
| .iter() | ||
| .any(|s| event.issue.title.contains(s)) |
There was a problem hiding this comment.
Any particular reason to not make this case-insensitive? Seems like making it insensitive could make it a little less likely to have false-positives.
There was a problem hiding this comment.
Obviously it makes the implementation more complicated, but the real reason is that it reduces specificity.
Capitalization can be used to disambiguate. For example, on rust-clippy, using the capitalized "Rustup" disambiguates between PRs updating from rust and ones just mentioning "rustup"
Since only the first letter in a word is capitalized, generally it only takes a couple more entries to exclude the various combinations if so desired.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 25, 2023
triagebot exclude_labels -> exclude_titles rust-lang/triagebot#1720
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Sep 25, 2023
disable no-merges check for now It leads to false warnings on sync PRs until rust-lang/triagebot#1720 lands.
pitaj
force-pushed
the
no-merges_exclude-titles
branch
2 times, most recently
from
126cac5
to
f106af7
Compare
also don't re-add labels if they're manually removed labels are not always set atomically when opening a PR example: rust-lang/miri#3059
pitaj
force-pushed
the
no-merges_exclude-titles
branch
from
f106af7
to
7fb447a
Compare
ehuss
approved these changes
Oct 6, 2023
Mark-Simulacrum
pushed a commit
to rust-lang/rust-forge
that referenced
this pull request
Oct 16, 2023
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Oct 16, 2023
…ip1995 triagebot no-merges: exclude "Rustup"s, add labels rust-lang/triagebot#1720 changelog: none
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Oct 16, 2023
triagebot: re-enable merge commit check rust-lang/triagebot#1720 has landed. Also make the keyword "Rustup", which is what we've been already using for such PRs for a while. Just adjust the bot to also put that in the title.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Oct 21, 2023
triagebot: re-enable merge commit check rust-lang/triagebot#1720 has landed. Also make the keyword "Rustup", which is what we've been already using for such PRs for a while. Just adjust the bot to also put that in the title.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also don't re-add labels if they're manually removed
labels are not always set atomically when opening a PR example: rust-lang/miri#3059
Forge change: rust-lang/rust-forge#701